From f7975dca2a93e35bda1f363292c466ed2fd93aa7 Mon Sep 17 00:00:00 2001
From: Nic-Sevic <47717887+Nic-Sevic@users.noreply.github.com>
Date: Tue, 17 Sep 2024 11:56:14 -0700
Subject: [PATCH 1/2] Add: documentation for AssignmentInTernaryCondition sniff

---
 .../AssignmentInTernaryConditionStandard.xml  | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml

diff --git a/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml b/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml
new file mode 100644
index 0000000000..278b4b475a
--- /dev/null
+++ b/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml
@@ -0,0 +1,19 @@
+<documentation title="Assignment In Ternary Condition">
+<standard>
+    <![CDATA[
+        Checks that variable assignment does not occur in conditional statement of ternary. Condition must be in parentheses to be checked; Ternaries lacking parentheses around condition are skipped. If incorrect will throw: "Variable assignment found within a condition. Did you mean to do a comparison?"
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: Variable assigned with comparison in parentheses.">
+        <![CDATA[
+echo $mode = ( <em>$a == 'a'</em> ) ? 'b' : 'c';
+        ]]>
+        </code>
+        <code title="Invalid: Parentheses used but variable assignment instead of comparison.">
+        <![CDATA[
+echo $mode = ( <em>$a = 'a'</em> ) ? 'b' : 'c';
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>

From 9d85cf69f357a036e39d41c0f2d68af7e51ae54b Mon Sep 17 00:00:00 2001
From: Nic-Sevic <47717887+Nic-Sevic@users.noreply.github.com>
Date: Tue, 17 Sep 2024 16:01:05 -0700
Subject: [PATCH 2/2] fix: syntax issues, clarify desc and code comparison

---
 .../AssignmentInTernaryConditionStandard.xml  | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml b/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml
index 278b4b475a..88a6c36f98 100644
--- a/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml
+++ b/WordPress/Docs/CodeAnalysis/AssignmentInTernaryConditionStandard.xml
@@ -1,18 +1,23 @@
-<documentation title="Assignment In Ternary Condition">
-<standard>
+<?xml version="1.0"?>
+<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd" 
+    title="Assignment In Ternary Condition"
+    >
+    <standard>
     <![CDATA[
-        Checks that variable assignment does not occur in conditional statement of ternary. Condition must be in parentheses to be checked; Ternaries lacking parentheses around condition are skipped. If incorrect will throw: "Variable assignment found within a condition. Did you mean to do a comparison?"
+    Variables should not be assigned in conditional statement of ternary. 
+    Condition must be in parentheses to be checked; ternaries lacking parentheses around condition are skipped. 
     ]]>
     </standard>
     <code_comparison>
-        <code title="Valid: Variable assigned with comparison in parentheses.">
+        <code title="Valid: Conditional statement in parentheses and does not include variable assignment.">
         <![CDATA[
-echo $mode = ( <em>$a == 'a'</em> ) ? 'b' : 'c';
+        $mode = ( $a <em>==</em> 'a' ) ? 'b' : 'c';
         ]]>
         </code>
-        <code title="Invalid: Parentheses used but variable assignment instead of comparison.">
+        <code title="Invalid: Conditional statement in parentheses but includes variable assignment instead of comparison.">
         <![CDATA[
-echo $mode = ( <em>$a = 'a'</em> ) ? 'b' : 'c';
+        $mode = ( $a <em>=</em> 'a' ) ? 'b' : 'c';
         ]]>
         </code>
     </code_comparison>