This app uglifying cyrillic file names

[Flashwalker]

• I've searched the issue tracker and is pretty sure that there's no duplicate issue already filed
• I've built the latest development snapshot using the instructions in README and verified that the issue can still be reproduced (for bug reports)

EDIT: @brlin-tw : Fix Markdown markup

Issue Reproduce Instructions

1. Launch WoeUSB by running woeusbgui
2. Write windows image

Expected Behavior

Nice file names

Current Behavior

Ugly cyrillic file names like: �оказа�� ��ил� ди�ка

Info of My Environment

WoeUSB Version

0.2.10-2

WoeUSB Source

Installed from PyPi

Information about the Operating System

Pop!_OS 20.04 LTS x64

Information about the Source Media

"Windows 10"

Information about the Target Device

SP SD card 8GB (USB 3.0 cardrider)

[brlin-tw]

Seems to be related to FAT File System Filename Mojibake Issue · WoeUSB/WoeUSB Wiki

[brlin-tw]

The mount command call here:

WoeUSB-ng/WoeUSB/core.py

Lines 437 to 439 in 4d4910b

	if subprocess.run(["mount",
	target_partition,
	target_fs_mountpoint]).returncode != 0:

seems to be lacking appropriate FAT filesystem mount options to avoid mojibake-ing filenames, consider WoeUSB/WoeUSB's implementation:

https://github.com/WoeUSB/WoeUSB/blob/34b400d99d3c4089f487e1d4f7d71970b2d4429e/sbin/woeusb#L1496

[Flashwalker]

I forgot to mention that i used NTFS formated SD card

[brlin-tw]

I forgot to mention that i used NTFS formated SD card

Well then NTFS uses Unicode filenames thus the problem shouldn't happen.

The problem may be due to the incorrect handling of the mounting of the source filesystem, could you try running the following command to mount the original filesystem:

mkdir test_mountpoint
mount \
    --options loop,ro \
    --types udf,iso9660 \
    _source_iso_image_ \
    test_mountpoint

And verify that the filename isn't garbled in the mounted image?

Also, could you try running the Bash version of WoeUSB and verify the problem is still reproduced there?

[Flashwalker]

... And verify that the filename isn't garbled in the mounted image?...

I just tested and file name is ok on mount point http://0x0.st/oT74.png