selenium: Wait for the page to be fully loaded in Page.openTitle

umherirrender · umherirrender · commit f3f52ad5db29 · 2025-01-17T16:25:23.000Z
Return the returned promise from Page.openTitle to the caller

Follow-Up: Idd72732a749ee6657a8617cc0ecc7ab9f6217a69
Change-Id: I554f6358a97323fe2b9c172c8984bab3bd067434
diff --git a/tests/selenium/pageobjects/edit.page.js b/tests/selenium/pageobjects/edit.page.js
@@ -115,8 +115,8 @@ class EditPage extends Page {
 		return $( '.oo-ui-tool-name-editModeVisual' );
 	}
 
-	openForEditing( title ) {
-		super.openTitle( title, { veaction: 'edit', cxhidebetapopup: 1, hidewelcomedialog: 1, vehidebetadialog: 1 } );
+	async openForEditing( title ) {
+		return super.openTitle( title, { veaction: 'edit', cxhidebetapopup: 1, hidewelcomedialog: 1, vehidebetadialog: 1 } );
 	}
 
 	activationComplete() {

Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,8 @@ class EditPage extends Page {`
`115`	`115`	`return $( '.oo-ui-tool-name-editModeVisual' );`
`116`	`116`	`}`
`117`	`117`
`118`		`- openForEditing( title ) {`
`119`		`- super.openTitle( title, { veaction: 'edit', cxhidebetapopup: 1, hidewelcomedialog: 1, vehidebetadialog: 1 } );`
	`118`	`+ async openForEditing( title ) {`
	`119`	`+ return super.openTitle( title, { veaction: 'edit', cxhidebetapopup: 1, hidewelcomedialog: 1, vehidebetadialog: 1 } );`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`activationComplete() {`