Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark button #12

Open
Aniket762 opened this issue Oct 6, 2020 · 16 comments
Open

Add dark button #12

Aniket762 opened this issue Oct 6, 2020 · 16 comments
Assignees
Labels

Comments

@Aniket762
Copy link
Member

Make the website have both light mode and dark mode button which can be switched with a button placed in Navbar.

@Aniket762 Aniket762 added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed HTML CSS JavaScript hacktoberfest hacktoberfest2020 labels Oct 6, 2020
@ashutosh1401
Copy link

Could i contribute in this issue

@Aniket762
Copy link
Member Author

@ashutosh1401 Go ahead 😁

@swagat-das
Copy link

Interested for it. Can you assign it to me ?

@Aniket762
Copy link
Member Author

Hey @swagat-das good to see you here 🤗

Go for it!

Happy coding 😁

@Aniket762
Copy link
Member Author

@swagat-das @ashutosh1401 checkout the navbar and place your toggle button in that 😄

@swagat-das
Copy link

@Aniket762 I have to work in index.html, right ??

Coz there are some other HTML files also..

@Aniket762
Copy link
Member Author

Hey @swagat-das ,
Wait someone else is doing the UI for home screen then you will have the total thing in index and add the dark mode then.

Else conflicts may occur so better when he finishes you do!

Till then it will be great if you can help us in listing out the course material

@swagat-das
Copy link

How may I help in listing course material?

@swagat-das
Copy link

Shall I start working @Aniket762 on the dark mode option ??

@Aniket762
Copy link
Member Author

Aniket762 commented Oct 8, 2020

Hey @swagat-das sure man , you have great designing and graphics skills go for it and make the dark mode look as great as your art works 💪. Don't forget to share screenshots!

Happy Coding 😁

@Aniket762
Copy link
Member Author

Could i contribute in this issue

Hey mate you didn't reply neither create a PR so I unassigned you.

@swagat-das
Copy link

Hey @swagat-das sure man , you have great designing and graphics skills go for it and make the dark mode look as great as your art works 💪. Don't forget to share screenshots!

Happy Coding 😁

Yaa sure. I will be happy to contribute in it.

@swagat-das
Copy link

abc

Here's the dark mode button I have added.
Check out, if it's okay to merge. @Aniket762

@Aniket762
Copy link
Member Author

Hey @swagat-das can you please change the green color! You can even change the background image you have good designing skills I am sure you will make it look great . And it looks a bit pixelated is it?

Thanks for adding the dark mode though 😀

@swagat-das
Copy link

Actually, I use the darkmode.js library. In that, it's not possible to change the background image... @Aniket762

@abhibhaw
Copy link
Contributor

abhibhaw commented Oct 9, 2020

@swagat-das Consider changing that rocket background image. Except that neon shade, it's great!

And please send the PR as well!

I will suggest you to try your custom js skills, because darkmode.js may not suit well with this project.

Try this Reference

@sumana2001 sumana2001 removed documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants