Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color does not export #33

Open
Hunanbean-Collective opened this issue Dec 3, 2023 · 2 comments
Open

Color does not export #33

Hunanbean-Collective opened this issue Dec 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Hunanbean-Collective
Copy link

The Cell Color does not export. i am not sure if i am missing something, or if this is a legitimate issue. I think the later.
I have tried in 2 different Firefox based browsers and 1 chrome based.

Thanks

@wassfila
Copy link
Member

wassfila commented Dec 3, 2023

I confirm, this is not intended and it would be cool that in case colors are used that they get exported as well
The current logic has not been developed with that in scope and a dedicated rendering is run when exporting in order to allow segmented export to include and exclude types (seeds, cells, edges). The color randomness has also been appended separately by a community contributor @neuroradiology
I see there is a param for including colors here
https://github.com/WebSVG/voronoi/blob/b9f29ecc74078cfd5c036909c595f7eb7d39dce4/src/voronoi_diag.js#L400C34-L400C40

but a better approach would be to export colors that are currently visible by the users.
This project is not in active development, but when I have time I'll be checking this as next improvement

@wassfila wassfila added bug Something isn't working enhancement New feature or request labels Dec 3, 2023
@wassfila wassfila self-assigned this Dec 3, 2023
@Hunanbean-Collective
Copy link
Author

That would be great, thanks! I am using Voronoi for a Cell Bombing technique in Unreal Engine, but it uses the color information to actually do placement. so i am out of luck at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants