Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/73 iphone navbar bug #75

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Conversation

ttraenkler
Copy link
Contributor

Fixes #73

On these models when scrolling down the browser bottom button bar disappears but when trying to click on the wasm summit navbar, it pops back up again. instead, i hide the summit navbar on scroll down and it only comes back when scrolling up - this way both more content is visible and the bug is solved.

Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, great use of hooks in my opinion 😄

And worked for me:

localhost_3000_(Pixel 2 XL)

Approved! 😄 👍

@ttraenkler ttraenkler merged commit b098f04 into dev Jan 10, 2020
@ttraenkler ttraenkler deleted the feature/73-iphone-navbar-bug branch January 10, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navbar not easily clickable on iPhone without home button
2 participants