Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landing page layout refinements #79

Merged
merged 4 commits into from
Jan 11, 2020
Merged

landing page layout refinements #79

merged 4 commits into from
Jan 11, 2020

Conversation

ttraenkler
Copy link
Contributor

Fixes #64

Bildschirmfoto 2020-01-11 um 02 13 52
Bildschirmfoto 2020-01-11 um 02 14 09

@ttraenkler ttraenkler added enhancement New feature or request needs review labels Jan 11, 2020
@ttraenkler ttraenkler self-assigned this Jan 11, 2020
torch2424
torch2424 reviewed Jan 11, 2020
View reviewed changes
Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the code looks great, and works on my machine, I like how it no longer scrolls on desktop 😄

However, there are certain resolutions where it gets cut off (about 511px width):

Screenshot from 2020-01-11 02-14-58

@ttraenkler
Copy link
Contributor Author

ttraenkler commented Jan 11, 2020 •
edited
Loading

@torch2424 Yeah I’ve tried hard to get it right on all resolutions. Can we make this a separate issue?

torch2424
torch2424 approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, let's do a separate issue @ttraenkler 😄

@ttraenkler ttraenkler merged commit 8cd7527 into dev Jan 11, 2020
@ttraenkler ttraenkler mentioned this pull request Jan 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torch2424 torch2424 torch2424 approved these changes

@ashleygwilliams ashleygwilliams Awaiting requested review from ashleygwilliams

Assignees

@ttraenkler ttraenkler

Labels
enhancement New feature or request needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve responsive layout of landing page
2 participants
@ttraenkler @torch2424