Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed videos for individual talks #118

Closed
surma opened this issue Feb 19, 2020 · 10 comments
Closed

Embed videos for individual talks #118

surma opened this issue Feb 19, 2020 · 10 comments
Assignees

Comments

@surma
Copy link
Member

surma commented Feb 19, 2020

Playlist here:

https://www.youtube.com/playlist?list=PL6ed-L7Ni0yQ1pCKkw1g3QeN2BQxXvCPK

@torch2424
Copy link
Contributor

@ttraenkler @ashleygwilliams I've been super busy with new job stuff. Would ya'll be down to pick this up? Otherwise I can try and get it done sometime this weekend before my onboarding 😄

@ttraenkler ttraenkler self-assigned this Feb 20, 2020
@ttraenkler
Copy link
Contributor

Sure, I will do this. Was planning to do this after work yesterday but a family member got hospitalised.

@pranjal9599
Copy link
Contributor

pranjal9599 commented Feb 20, 2020

Hey i can embed the talks which page should be more suitable i was thinking of adding youtube links in schedule page and then embed on every individual speaker page? And replacing livestream link with a page of talks?

@ttraenkler
Copy link
Contributor

ttraenkler commented Feb 21, 2020

Hi @pranjal9599, thanks for offering your help. Personally I like your proposal, but let's place it only on the indidivual speaker pages. While I proposed to add abstract and picture to the schedule, our consensus was to keep only the speaker and talk title on the schedule and the rest on the individual speaker page and I think this decision carries over to the video embedding. However personally I am open to your suggestion if the others agree.

@ttraenkler ttraenkler removed their assignment Feb 21, 2020
@pranjal9599
Copy link
Contributor

Added on the speaker pages keynotes one need some work

image

image

image

@ttraenkler
Copy link
Contributor

ttraenkler commented Feb 21, 2020

@pranjal9599 Cool, thanks! I feel the cards look a bit unbalanced now next to the videos - we could either try to fix them or just remove them altogether, what do the others think? About the collapsing layout for the keynote talks, I had a fix for this in the branch referenced here if that helps that was not merged if you want to peek here #97 . This not only fixed the collapsing layout, but also made the cards a bit taller to take up the space better and the same format as those on the speakers page, which you might try out if it looks better.

@ttraenkler
Copy link
Contributor

@pranjal9599 Please let me know if you are still working on this. I am currently sick - in case you are not let me know then I will take over once I have recovered.

@pranjal9599
Copy link
Contributor

Hi @ttraenkler I got caught up in somethings will try to make them by tonight or else you can take over. Hope you recover soon.

@ttraenkler
Copy link
Contributor

@pranjal9599 OK, I will take over now. I have still not recovered but it should only take a few minutes.

@ttraenkler
Copy link
Contributor

ttraenkler commented Feb 27, 2020

@pranjal9599 I've merged your branch into mine, fixed the layout problems, removed the speaker cards plus some minor refinements (for screenshots see #120).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants