Skip to content

Commit b3cfd12

Browse files
authored
Merge pull request #52 from yurydelendik/fix-jspi-tests
Fix JSPI tests
2 parents 214c595 + 25d0481 commit b3cfd12

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

test/js-api/js-promise-integration/js-promise-integration.any.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ test(() => {
3232

3333
test(() => {
3434
let builder = new WasmModuleBuilder();
35-
builder.addGlobal(kWasmI32, true, false).exportAs('g');
35+
builder.addGlobal(kWasmI32, true).exportAs('g');
3636
builder.addFunction("test", kSig_i_v)
3737
.addBody([
3838
kExprI32Const, 42,
@@ -41,7 +41,7 @@ test(() => {
4141
let instance = builder.instantiate();
4242
let wrapper = WebAssembly.promising(instance.exports.test);
4343
wrapper();
44-
assertEquals(42, instance.exports.g.value);
44+
assert_equals(42, instance.exports.g.value);
4545
});
4646

4747
promise_test(async () => {
@@ -161,7 +161,7 @@ promise_test(async () => {
161161
let wrapped_export = Promising(instance.exports.test);
162162

163163
// AbeforeB.showAbeforeB();
164-
exported_promise = wrapped_export();
164+
let exported_promise = wrapped_export();
165165
// AbeforeB.showAbeforeB();
166166

167167
AbeforeB.setB();
@@ -189,7 +189,7 @@ promise_test(async () => {
189189

190190
let wrapped_export = Promising(instance.exports.test);
191191

192-
exported_promise = wrapped_export();
192+
let exported_promise = wrapped_export();
193193
AbeforeB.setB();
194194

195195
assert_equals(await exported_promise, 42);
@@ -389,9 +389,7 @@ test(() => {
389389
builder.addFunction("export", kSig_v_v).addBody([]).exportFunc();
390390
let instance = builder.instantiate();
391391
let export_wrapper = WebAssembly.promising(instance.exports.export);
392-
let export_sig = export_wrapper.type();
393-
assert_array_equals(export_sig.parameters, []);
394-
assert_array_equals(export_sig.results, ['externref']);
392+
assert_true(export_wrapper instanceof Function);
395393
});
396394

397395
promise_test(async (t) => {
@@ -403,7 +401,7 @@ promise_test(async (t) => {
403401
let instance = builder.instantiate();
404402
let wrapper = WebAssembly.promising(instance.exports.test);
405403

406-
promise_rejects(t, RangeError, wrapper(),/Maximum call stack size exceeded/);
404+
promise_rejects(t, new Error(), wrapper(), /Maximum call stack size exceeded/);
407405
});
408406

409407
promise_test(async (t) => {
@@ -440,7 +438,7 @@ promise_test(async (t) => {
440438
}});
441439
// export1 (promising)
442440
let wrapper = WebAssembly.promising(instance.exports.export1);
443-
promise_rejects(t, WebAssembly.RuntimeError, wrapper(),
441+
promise_rejects(t, new WebAssembly.RuntimeError(), wrapper(),
444442
/trying to suspend JS frames/);
445443
});
446444

test/js-api/wasm-module-builder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,7 @@ class WasmModuleBuilder {
966966
}
967967
let type_index = (typeof type) == "number" ? type : this.addType(type);
968968
this.imports.push({module: module, name: name, kind: kExternalFunction,
969-
type: type_index});
969+
type_index: type_index});
970970
return this.num_imported_funcs++;
971971
}
972972

0 commit comments

Comments
 (0)