Replies: 1 comment
-
Opened a PR: #7525 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Continuing the discussion in #7507, here's what has already been decided:
getExpressionInfo
should be rewritten to just return an object made from the corresponding wrapper.getExpressionInfo
should be deprecated and replaced with a function that returns an expression wrapper for an expression of unknown class. Maybe we can makeExpression
constructor return the specific instance? Can we just make the instruction-building functions return expression wrappers? That shouldn't be a breaking change, as expression wrappers can be implicitly converted to Wasm pointers viavalueOf
(e.g.+expr
orexpr | 0
).Is there something else to add or clarify?
Beta Was this translation helpful? Give feedback.
All reactions