Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session breaks when more than one tab is open #5567

Open
sentx-io opened this issue Dec 22, 2024 · 1 comment
Open

Session breaks when more than one tab is open #5567

sentx-io opened this issue Dec 22, 2024 · 1 comment
Labels
type: bug Something isn't working

Comments

@sentx-io
Copy link

Wallet Connect will fail to return a transaction result to the source window as soon as a new tab is opened. It will actually return it to the wrong one instead, and the window that initially sent the transaction to be executed will never receive the acknowledgement from the wallet.

To reproduce:

Connect to a Dapp using Wallet Connect
Open a new tab in the same url
Execute a transaction on tab A and simply hit reject on the wallet
Execute a transaction on tab B and reject
One of the tabs will never get the ping back from the wallet. Instead, all of them will go to the same source window, whether or not it was the one that sent the transaction to be executed.

This is a big limitation and makes Wallet Connect very unreliable on any DApp where users often have multiple windows or tabs open (stats, analytics, feeds, market trades).

@sentx-io sentx-io added the type: bug Something isn't working label Dec 22, 2024
Copy link

linear bot commented Dec 22, 2024

@WalletConnect WalletConnect deleted a comment Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant