Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WallGoCollisions imports in WallGo #310

Open
og113 opened this issue Oct 17, 2024 · 0 comments
Open

WallGoCollisions imports in WallGo #310

og113 opened this issue Oct 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@og113
Copy link
Collaborator

og113 commented Oct 17, 2024

From Lauri's comment on PR #305

  • The whole logic behind loading WallGoCollision internally could use polish and I'm not sure what the best approach here would be. The main complication is that if we want to allow WallGo to be used without WallGoCollision installed, we can't import eg. collisionHelpers.py into the WallGo package without first checking that WallGoCollision can be successfully imported.
@og113 og113 added the enhancement New feature or request label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant