Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wall solver reports final wall velocity even though the pressure if still large #289

Open
niemilau opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@niemilau
Copy link
Collaborator

niemilau commented Oct 7, 2024

When testing collisions with the Yukawa model the wall solving seemed to behave weirdly. In one instance it tried:
vw = 0.621781, 0.001, 0.002, 0.004, 0.0518086, 0.00458875, 0.004 (again!)
and then reported vw = 0.00400 as the final wall speed, even though the pressure was still of order 1e+06.

The small velocities here are probably in part due to incorrect collision model (which I didn't check), but even still this seems like a bug in the wall solver.

Edit: it also reports a very large error:
wallVelocityError: 0.541702

Steps to reproduce:

Go to branch ChangeCollisionConventions (will be on main soon), recompile and install the collision module and run:
python Models/Yukawa/yukawa.py --recalculateCollisions --momentumGridSize 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant