forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Labels
Estimate: < 6 Hourscategory: performanceperformance-related issuesperformance-related issuescategory: stylesaffects lots of styles, requiring visual testingaffects lots of styles, requiring visual testing
Milestone
Description
The basic proposal:
- Remove the Main Nav
- Put the Sticky Nav in the Main Nav slot, with all its resizing-related code
- If the sticky flag is checked, use https://caniuse.com/#feat=css-sticky to pin it to the top of the viewport rather than JS.
Inspired by https://pudding.cool/process/scrollytelling-sticky/
Related tickets:
- stuff re: sticky nav How to customize Largo with sticky nav on all pages, including homepage #1627
- duplicate social media button IDs id #header-social is duplicated on page when sticky nav and global nav are present #1781
- text node within header image link: Output a text node within the header image's link so that the link has text. #1783
- Header Widget Area doesn't show on mobile: Optional Header Widget Area on mobile screens #1650
- consider whether we'd want to use Flexbox to evenly space these items: evenly spacing nav items / flexbox? #1608
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Estimate: < 6 Hourscategory: performanceperformance-related issuesperformance-related issuescategory: stylesaffects lots of styles, requiring visual testingaffects lots of styles, requiring visual testing