Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: additional request header to indicate a Critical-CH restart #87

Open
amtunlimited opened this issue Oct 6, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@amtunlimited
Copy link
Collaborator

Could be helpful for a number of reasons, including deduplication for analytics and better handling of still-missing headers.

Could call it Critical-CH-Restart or something, I'm thinking along the lines of Service-Worker-Navigation-Preload.

@arichiv
Copy link
Collaborator

arichiv commented Oct 7, 2021

@abeyad @miketaylr

@abeyad
Copy link
Contributor

abeyad commented Oct 7, 2021

As a side note, I think Critical-CH-Restart should be a boolean; I don't think a count doesn't make sense since Critical-CH should only result in up to one resend of the request.

@amtunlimited
Copy link
Collaborator Author

@davidben since you own the spec (in a way), any thoughts?

@abeyad that's actually not quite true anymore. The Critical-CH restarts are now counted as part of the navigation redirect limit, so there could be a number of times.

That being said, there's a question of if the header should persist through a redirect chain, or just on the one "restarted" request. I was leaning towards just a boolean and not passed to the next redirect

@amtunlimited amtunlimited self-assigned this Oct 7, 2021
@davidben
Copy link
Contributor

davidben commented Oct 7, 2021

better handling of still-missing headers

What kind of better handling were you envisioning? The server is equally obligated to respond to the missing headers in both requests. On the first request, if you send Critical-CH, the client may well choose not to restart, in which case the response is used as-is.

@amtunlimited
Copy link
Collaborator Author

I suppose I was envisioning a server seeing that header and gracefully handling, vs not seeing it and assuming it will be dropped, but that's probably not a good precedent to set

@davidben
Copy link
Contributor

davidben commented Oct 7, 2021

Yeah, such a server would break if the client doesn't support the hint, or declined to send it for some reason.

@arichiv arichiv added the enhancement New feature or request label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants
@davidben @arichiv @abeyad @amtunlimited and others