From 3589018d353ea17f3a3ef96fd74581da393f0afe Mon Sep 17 00:00:00 2001 From: eric-burel Date: Wed, 24 Jun 2020 10:27:38 +0200 Subject: [PATCH] update package, provide a repro for failign SSR import --- .meteor/packages | 5 +++++ .meteor/versions | 6 +++++- .../vulcan-backoffice/lib/components/BackofficeIndex.jsx | 5 +++-- packages/vulcan-backoffice/package.js | 2 +- .../lib/components/backoffice/BackofficeNavbar.jsx | 6 ++++-- 5 files changed, 18 insertions(+), 6 deletions(-) diff --git a/.meteor/packages b/.meteor/packages index 5e4db55359..7ea44292b6 100644 --- a/.meteor/packages +++ b/.meteor/packages @@ -14,7 +14,12 @@ accounts-password@1.6.0 # accounts-facebook vulcan:debug +# To run the backoffice vulcan:backoffice +vulcan:accounts +# Ui vulcan:ui-bootstrap +# vulcan:ui-material + meteortesting:mocha apollo diff --git a/.meteor/versions b/.meteor/versions index f291aa1300..b022bb4103 100644 --- a/.meteor/versions +++ b/.meteor/versions @@ -63,12 +63,14 @@ ordered-dict@1.1.0 promise@0.11.2 random@1.2.0 rate-limit@1.0.9 +reactive-dict@1.3.0 reactive-var@1.0.11 reload@1.3.0 retry@1.1.0 routepolicy@1.1.0 server-render@0.3.1 service-configuration@1.0.11 +session@1.2.0 sha@1.0.9 shell-server@0.5.0 socket-stream-client@0.2.3 @@ -81,14 +83,16 @@ templating-tools@1.1.2 tracker@1.2.0 underscore@1.0.10 url@1.2.0 +vulcan:accounts@1.15.1 vulcan:backoffice@1.15.1 vulcan:core@1.15.1 vulcan:debug@1.15.1 vulcan:email@1.15.1 +vulcan:forms@1.15.1 vulcan:i18n@1.15.1 vulcan:i18n-en-us@1.15.1 vulcan:lib@1.15.1 -vulcan:ui-bootstrap@1.15.1 +vulcan:ui-material@1.15.1 vulcan:users@1.15.1 webapp@1.9.1 webapp-hashing@1.0.9 diff --git a/packages/vulcan-backoffice/lib/components/BackofficeIndex.jsx b/packages/vulcan-backoffice/lib/components/BackofficeIndex.jsx index 31bc895209..6dab0a58ab 100644 --- a/packages/vulcan-backoffice/lib/components/BackofficeIndex.jsx +++ b/packages/vulcan-backoffice/lib/components/BackofficeIndex.jsx @@ -2,7 +2,8 @@ import React from 'react'; import { Components, registerComponent } from 'meteor/vulcan:core'; import NoSSR from 'react-no-ssr'; -const BackofficeIndex = () => ( +const BackofficeIndex = () => { + return (

Welcome to Vulcan autogenerated backoffice

{/** AccountsLoginForm is SSR only */} @@ -12,7 +13,7 @@ const BackofficeIndex = () => (
-); +);}; registerComponent({ name: 'VulcanBackofficeIndex', component: BackofficeIndex, hocs: [] }); export default BackofficeIndex; diff --git a/packages/vulcan-backoffice/package.js b/packages/vulcan-backoffice/package.js index 85c014ab88..7855b476b1 100755 --- a/packages/vulcan-backoffice/package.js +++ b/packages/vulcan-backoffice/package.js @@ -6,7 +6,7 @@ Package.describe({ }); Package.onUse(api => { - api.use(['vulcan:core@=1.15.1', 'vulcan:i18n@=1.15.1']); + api.use(['vulcan:core@=1.15.1', 'vulcan:i18n@=1.15.1', 'vulcan:accounts@1.15.1']); api.mainModule('lib/server/main.js', 'server'); api.mainModule('lib/client/main.js', 'client'); diff --git a/packages/vulcan-ui-material/lib/components/backoffice/BackofficeNavbar.jsx b/packages/vulcan-ui-material/lib/components/backoffice/BackofficeNavbar.jsx index c71872bd5d..99c195cfa8 100644 --- a/packages/vulcan-ui-material/lib/components/backoffice/BackofficeNavbar.jsx +++ b/packages/vulcan-ui-material/lib/components/backoffice/BackofficeNavbar.jsx @@ -7,7 +7,9 @@ import IconButton from '@material-ui/core/IconButton'; import MenuIcon from 'mdi-material-ui/Menu'; import { Link } from 'react-router-dom'; -const BackofficeNavbar = ({ onClick, basePath }) => ( +const BackofficeNavbar = ({ onClick, basePath }) => { + // console.log('Icon render', MenuIcon); // @see https://github.com/VulcanJS/Vulcan/issues/2580 + return ( @@ -19,6 +21,6 @@ const BackofficeNavbar = ({ onClick, basePath }) => ( -); +);}; registerComponent('VulcanBackofficeNavbar', BackofficeNavbar);