Skip to content

Commit e412a8b

Browse files
committed
fix: Set the overall status in pr_helper
1 parent 980161e commit e412a8b

File tree

1 file changed

+26
-4
lines changed

1 file changed

+26
-4
lines changed

voron_toolkit/voronuser_utils/pr_helper.py

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,16 +176,18 @@ def _update_pr_comment(self: Self, pr_number: int) -> None:
176176
)
177177

178178
def _update_status_checks(self: Self, commit_sha: str) -> None:
179+
failed: bool = False
179180
for ci_step_result in self.tool_results.values():
180181
result_ok = ExtendedResultEnum.WARNING if ci_step_result.tool_ignore_warnings else ExtendedResultEnum.SUCCESS
181182
if ci_step_result.extended_result > result_ok:
183+
failed = True
182184
GithubActionHelper.set_commit_status(
183185
repo=self.github_repository,
184186
commit_sha=commit_sha,
185187
status=StatusCheck(
186188
status="failure",
187-
description=f"CI found issues in {ci_step_result.tool_name}!",
188-
context=f"VoronCI/{ci_step_result.tool_name}",
189+
description=f"{ci_step_result.tool_name} found issues!",
190+
context=f"VoronCI/{ci_step_result.tool_id}",
189191
),
190192
)
191193
else:
@@ -194,10 +196,30 @@ def _update_status_checks(self: Self, commit_sha: str) -> None:
194196
commit_sha=commit_sha,
195197
status=StatusCheck(
196198
status="success",
197-
description=f"CI found no issues in {ci_step_result.tool_name}!",
198-
context=f"VoronCI/{ci_step_result.tool_name}",
199+
description=f"{ci_step_result.tool_name} found no issues!",
200+
context=f"VoronCI/{ci_step_result.tool_id}",
199201
),
200202
)
203+
if failed:
204+
GithubActionHelper.set_commit_status(
205+
repo=self.github_repository,
206+
commit_sha=commit_sha,
207+
status=StatusCheck(
208+
status="failure",
209+
description="Issues found, please check the PR comment!",
210+
context="VoronCI/run",
211+
),
212+
)
213+
else:
214+
GithubActionHelper.set_commit_status(
215+
repo=self.github_repository,
216+
commit_sha=commit_sha,
217+
status=StatusCheck(
218+
status="success",
219+
description="No issues found by CI!",
220+
context="VoronCI/run",
221+
),
222+
)
201223

202224
def _post_process_pr(self: Self, pr_number: int, pr_action: str, commit_sha: str) -> None:
203225
logger.info("Post Processing PR #{}, action: {}", pr_number, pr_action)

0 commit comments

Comments
 (0)