webkitSupportsPresentationMode("picture-in-picture") is not reliable on mobile safari

tmm1 · tmm1 · commit 4d39d228c261 · 2017-05-03T17:46:42.000-07:00
diff --git a/dist/videojs.pip.js b/dist/videojs.pip.js
@@ -72,7 +72,7 @@ var PipButton = function PipButton(options) {
 
   if (video.webkitSupportsPresentationMode && typeof video.webkitSetPresentationMode === "function") {
     player.on('loadeddata', function () {
-      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && video.webkitSupportsPresentationMode("picture-in-picture")) {
+      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && !window.navigator.userAgent.match(/iPhone/)) {
         var PipToggle = this.controlBar.addChild('PipToggle', options);
         player.controlBar.el().insertBefore(PipToggle.el(), player.controlBar.fullscreenToggle.el());
       }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "videojs-pip",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "video.js plugin to add a PIP button if the browser supports webkitSupportsPresentationMode",
   "repository": {
     "type": "git",
diff --git a/videojs-pip.js b/videojs-pip.js
@@ -41,7 +41,7 @@ const PipButton = function(options) {
 
   if (video.webkitSupportsPresentationMode && typeof video.webkitSetPresentationMode === "function") {
     player.on('loadeddata', function() {
-      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && video.webkitSupportsPresentationMode("picture-in-picture")) {
+      if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && !window.navigator.userAgent.match(/iPhone/)) {
         var PipToggle = this.controlBar.addChild('PipToggle', options)
         player.controlBar.el().insertBefore(PipToggle.el(), player.controlBar.fullscreenToggle.el())
       }

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ var PipButton = function PipButton(options) {`
`72`	`72`
`73`	`73`	`if (video.webkitSupportsPresentationMode && typeof video.webkitSetPresentationMode === "function") {`
`74`	`74`	`player.on('loadeddata', function () {`
`75`		`- if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && video.webkitSupportsPresentationMode("picture-in-picture")) {`
	`75`	`+ if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && !window.navigator.userAgent.match(/iPhone/)) {`
`76`	`76`	`var PipToggle = this.controlBar.addChild('PipToggle', options);`
`77`	`77`	`player.controlBar.el().insertBefore(PipToggle.el(), player.controlBar.fullscreenToggle.el());`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "videojs-pip",`
`3`		`- "version": "1.0.2",`
	`3`	`+ "version": "1.0.3",`
`4`	`4`	`"description": "video.js plugin to add a PIP button if the browser supports webkitSupportsPresentationMode",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ const PipButton = function(options) {`
`41`	`41`
`42`	`42`	`if (video.webkitSupportsPresentationMode && typeof video.webkitSetPresentationMode === "function") {`
`43`	`43`	`player.on('loadeddata', function() {`
`44`		`- if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && video.webkitSupportsPresentationMode("picture-in-picture")) {`
	`44`	`+ if (!player.controlBar.childNameIndex_.hasOwnProperty('PipToggle') && !window.navigator.userAgent.match(/iPhone/)) {`
`45`	`45`	`var PipToggle = this.controlBar.addChild('PipToggle', options)`
`46`	`46`	`player.controlBar.el().insertBefore(PipToggle.el(), player.controlBar.fullscreenToggle.el())`
`47`	`47`	`}`