Skip to content
This repository was archived by the owner on Oct 11, 2019. It is now read-only.

Proposed additional fixes to external authentication. #558

@keberle

Description

@keberle

The pull request I submitted 12 days ago to eliminate the AzureAD config from throwing an exception at startup addressed our need to be able to login to the admin UI with AzureAD (or other OpenID Connect option) but to get that working in a kubernetes container I need forwarded header support. Otherwise, the protocol on the callback url is wrong behind a proxy.

I have that working and it doesn't break anything but it doesn't do me any good to submit that in a pull request is the AzureAD fix is going to be rejected. Can someone weigh in on whether that fix to the startup issue is acceptable before I submit the forwarded headers support pull request?

Thanks.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions