Description
selfmodel.sh has 4 shellcheck warnings (our CI runs with --severity=error so they don't fail the build, but they should be fixed):
- SC2034:
SELFMODEL_REPO variable appears unused (line 8)
- SC2059: Variables in printf format string (line 370)
- SC2012: Use find instead of ls (line 628)
- SC2126: Use
grep -c instead of grep | wc -l (line 783)
Files to modify
Acceptance criteria
Description
selfmodel.shhas 4 shellcheck warnings (our CI runs with--severity=errorso they don't fail the build, but they should be fixed):SELFMODEL_REPOvariable appears unused (line 8)grep -cinstead ofgrep | wc -l(line 783)Files to modify
scripts/selfmodel.shAcceptance criteria
shellcheck --severity=style scripts/selfmodel.shpasses clean