Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code for conflicts and dependencies #58

Open
ggazzi opened this issue Jul 26, 2017 · 1 comment
Open

Duplicated code for conflicts and dependencies #58

ggazzi opened this issue Jul 26, 2017 · 1 comment
Labels
code quality

Comments

@ggazzi
Copy link
Member

ggazzi commented Jul 26, 2017

The modules that implement the search for conflicts and dependencies have lot of duplicated code. In particular, some pushout complements are calculated in multiple places, some searches for morphisms are repeated in multiple places. We should try to reduce this duplication.
@ggazzi
Copy link
Member Author

ggazzi commented Jul 26, 2017

Why are there multiple functions findAllDeleteUse, findAllProduceForbid, etc, instead of just one findAllConflicts whose result can be filtered as required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggazzi