Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage on Minecraft 1.19 #7

Open
haykam821 opened this issue Jun 11, 2022 · 2 comments
Open

Breakage on Minecraft 1.19 #7

haykam821 opened this issue Jun 11, 2022 · 2 comments

Comments

@haykam821
Copy link

The mixin likely needs to be moved to the CommandTreeS2CPacket.ArgumentNode.write method. Additional logging would be beneficial here for mods that do not register their argument types to the class map because of silent breakage introduced by the argument type refactor (mods should register using ArgumentTypeRegistry instead).

Note that argument types now sync using raw IDs as well, and Velocity seems to represent crossstitch:mod_argument as the raw ID -255.

@LaurenceBarnes
Copy link

I got this error spamming every few seconds, could that be related? https://pastebin.com/W9npq6dV

@haykam821
Copy link
Author

Yes, that mixin error is due to the argument type refactor. The pull request #8 which I opened fixes that error by moving the serialization to the new inner class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants