chore: updagrade eslint backend to 9.0 #1259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
1 similar comment
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of UserOfficeProject/issue-tracker#1488
Description
Our eslint version is end of life and out of support: https://eslint.org/version-support/ so I have updated the backend to 9.0.0 and will open new prs for the frontend and tests to avoid the prs form getting too big. 9.0.0 comes with a new config format so I have migreated to that however this has come with some rule updated and changes. I have tryed to keep the rules as consistant as before but in some cases it doesnt seem possible right now e.g. import-js/eslint-plugin-import#2721. I have also updated the code base to follow some new (or previously missing? idk) rules that seem sensible to follow.
I suggest reviewing this PR commit by commit to see the rule updates applyed one at a time and not all at once.
Motivation and Context
Eslint v8 is end of life and out of support
How Has This Been Tested
Created new eslint.config.js for v9, updated to code base to follow updated rules.
Fixes
Changes
Depends on
Tests included/Docs Updated?