write session data to filesystem immediately on cleanup

simonLeary42 · simonLeary42 · commit ab8aed0d0413 · 2025-12-12T13:13:07.000-05:00
diff --git a/resources/init.php b/resources/init.php
@@ -21,8 +21,6 @@
     set_error_handler(["UnityWebPortal\lib\UnityHTTPD", "errorHandler"]);
 }
 
-session_start();
-
 if (isset($GLOBALS["ldapconn"])) {
     $LDAP = $GLOBALS["ldapconn"];
 } else {
@@ -42,10 +40,13 @@
     $_SESSION["csrf_tokens"] = [];
 }
 
+session_start();
 // https://stackoverflow.com/a/1270960/18696276
 if (time() - ($_SESSION["LAST_ACTIVITY"] ?? 0) > CONFIG["site"]["session_cleanup_age_seconds"]) {
     $_SESSION["csrf_tokens"] = [];
     $_SESSION["messages"] = [];
+    session_write_close();
+    session_start();
 }
 $_SESSION["LAST_ACTIVITY"] = time();
 

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,6 @@`
`21`	`21`	`set_error_handler(["UnityWebPortal\lib\UnityHTTPD", "errorHandler"]);`
`22`	`22`	`}`
`23`	`23`
`24`		`-session_start();`
`25`		`-`
`26`	`24`	`if (isset($GLOBALS["ldapconn"])) {`
`27`	`25`	`$LDAP = $GLOBALS["ldapconn"];`
`28`	`26`	`} else {`
`@@ -42,10 +40,13 @@`
`42`	`40`	`$_SESSION["csrf_tokens"] = [];`
`43`	`41`	`}`
`44`	`42`
	`43`	`+session_start();`
`45`	`44`	`// https://stackoverflow.com/a/1270960/18696276`
`46`	`45`	`if (time() - ($_SESSION["LAST_ACTIVITY"] ?? 0) > CONFIG["site"]["session_cleanup_age_seconds"]) {`
`47`	`46`	`$_SESSION["csrf_tokens"] = [];`
`48`	`47`	`$_SESSION["messages"] = [];`
	`48`	`+ session_write_close();`
	`49`	`+ session_start();`
`49`	`50`	`}`
`50`	`51`	`$_SESSION["LAST_ACTIVITY"] = time();`
`51`	`52`