add test for worker remove-users-from-group.php

Author: simonLeary42

test/functional/WorkerRemoveUsersFromGroupTest.php

@@ -0,0 +1,70 @@
+<?php
+
+use PHPUnit\Framework\TestCase;
+use UnityWebPortal\lib\UnityUser;
+use UnityWebPortal\lib\UnityLDAP;
+
+class WorkerRemoveUsersFromGroupTest extends TestCase
+{
+    private function writeLinesToTmpFile(array $lines)
+    {
+        $file = tmpfile();
+        if (!$file) {
+            throw new RuntimeException("failed to make tmpfile");
+        }
+        $path = stream_get_meta_data($file)["uri"];
+        $contents = implode("\n", $lines);
+        $fwrite = fwrite($file, $contents);
+        if ($fwrite === false) {
+            throw new RuntimeException("failed to write to tmpfile '$path'");
+        }
+        return $file;
+    }
+
+    public function testRemoveUsersFromGroup()
+    {
+        global $USER, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK;
+        switchUser(...getUserIsPIHasNoMembersNoMemberRequests());
+        $pi = $USER;
+        $pi_group = $USER->getPIGroup();
+        $this->assertTrue($pi->isPI());
+        $this->assertEqualsCanonicalizing([$pi->uid], $pi_group->getGroupMemberUIDs(true));
+        $this->assertEqualsCanonicalizing([$pi->uid], $pi_group->getGroupMemberUIDs(false));
+        $this->assertEqualsCanonicalizing([], $pi_group->getRequests());
+        $uids = getSomeUIDsOfQualifiedUsersNotRequestedAccountDeletion();
+        $uids_to_remove = array_slice($uids, 0, 3);
+        $expected_new_uids = array_diff(array_merge([$pi->uid], $uids), $uids_to_remove);
+        $remove_uids_file = $this->writeLinesToTmpFile($uids_to_remove);
+        $remove_uids_file_path = stream_get_meta_data($remove_uids_file)["uri"];
+        try {
+            foreach ($uids as $uid) {
+                $user = new UnityUser($uid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
+                $pi_group->newUserRequest($user, false);
+                $pi_group->approveUser($user, false);
+            }
+            [$_, $output] = executeWorker(
+                "remove-users-from-group.php",
+                "$pi_group->gid $remove_uids_file_path",
+            );
+            print implode("\n", $output);
+            // our $LDAP is not aware of changes made by worker subprocess, so throw it out
+            unset($GLOBALS["ldapconn"]);
+            switchUser(...getUserIsPIHasNoMembersNoMemberRequests());
+            $pi = $USER;
+            $pi_group = $USER->getPIGroup();
+            $this->assertEqualsCanonicalizing(
+                $expected_new_uids,
+                $pi_group->getGroupMemberUIDs(false),
+            );
+            $this->assertEqualsCanonicalizing(
+                $expected_new_uids,
+                $pi_group->getGroupMemberUIDs(true),
+            );
+        } finally {
+            foreach ($uids as $uid) {
+                $user = new UnityUser($uid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
+                $pi_group->removeUser($user);
+            }
+        }
+    }
+}

test/phpunit-bootstrap.php

@@ -158,6 +158,30 @@ function http_get(string $phpfile, array $get_data = []): void
     }
 }
 
+/**
+ * runs a worker script
+ * @throws RuntimeException
+ * @return [return code, output lines]
+ */
+function executeWorker(string $basename, string $args, bool $doThrowIfNonzero = true): array
+{
+    $command = sprintf("%s %s/../workers/%s %s 2>&1", PHP_BINARY, __DIR__, $basename, $args);
+    $output = [];
+    $rc = null;
+    exec($command, $output, $rc);
+    if ($doThrowIfNonzero && $rc !== 0) {
+        throw new RuntimeException(
+            sprintf(
+                "command failed! command='%s' rc=%d output=%s",
+                $command,
+                $rc,
+                jsonEncode($output),
+            ),
+        );
+    }
+    return [$rc, $output];
+}
+
 // delete requests made by that user
 // delete user entry
 // delete user group entry
@@ -216,6 +240,7 @@ function ensureUserNotInPIGroup(UnityGroup $pi_group)
         $pi_group->removeUser($USER);
         ensure(!$pi_group->memberExists($USER));
     }
+    // FIXME removeUser already removes the uid from this redis, this shouldn't be necessary
     $REDIS->removeCacheArray(
         $pi_group->gid,
         "members",
@@ -338,3 +363,17 @@ function getAdminUser()
 {
     return ["[email protected]", "foo", "bar", "[email protected]"];
 }
+
+function getSomeUIDsOfQualifiedUsersNotRequestedAccountDeletion()
+{
+    return [
+        "user1_org1_test",
+        "user3_org1_test",
+        "user6_org1_test",
+        "user7_org1_test",
+        "user8_org1_test",
+        "user9_org3_test",
+        "user10_org1_test",
+        "user11_org1_test",
+    ];
+}