add enforcement, document convention

Author: simonLeary42

.pre-commit-config.yaml

@@ -103,7 +103,11 @@ repos:
         entry: bash ./test/assert-utils-used.bash
         language: system
         files: \.php$
-        exclude: ^resources/lib/utils\.php$
+        exclude: |
+          (?x)^(
+              ^resources/lib/utils\.php$|
+              ^test/.*\.php$|
+          )$
       - id: assert-exceptions-used
         name: Assert exceptions are used
         entry: bash ./test/assert-exceptions-used.bash

CONTRIBUTING.md

@@ -20,6 +20,8 @@
   This will throw an exception rather than returning `false`.
 - No code should call `mb_detect_encoding()`, instead `\mbDetectEncoding()`.
   This will enable strict mode and throw an exception rather than returning `false`.
+- No code should call `intval()`, instead `\str2int()`.
+  This will enable strict mode and throw an exception rather than issuing a warning.
 - `UnityHTTPD`'s user-facing error functionality (ex: `badRequest`) should only be called from `webroot/**/*.php`.
   `resources/**/*.php` should throw exceptions instead.
 - all pages under `webroot/admin/` must check for `$USER->isAdmin()` and call `UnityHTTPD::forbidden()` if not admin.

test/assert-utils-used.bash

@@ -10,6 +10,7 @@ declare -A utils=(
     ["json_encode"]="jsonEncode"
     ["mb_detect_encoding"]="mbDetectEncoding"
     ["mb_convert_encoding"]="mbConvertEncoding"
+    ["intval"]="str2int"
 )
 
 rc=0