use uids instead of objects for assertions

Author: simonLeary42

test/functional/PiMemberApproveTest.php

@@ -31,7 +31,7 @@ public function testApproveRequest()
         $pi = $USER;
         $piGroup = $USER->getPIGroup();
         $this->assertTrue($piGroup->exists());
-        $this->assertEquals([$pi], $piGroup->getGroupMembers());
+        $this->assertEquals([$pi->getUID()], $piGroup->getGroupMemberUIDs());
         $this->assertEmpty($piGroup->getRequests());
         $requestedUser = new UnityUser(self::$requestUid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
         try {
@@ -41,7 +41,7 @@ public function testApproveRequest()
             $piGroup->approveUser($requestedUser);
             $this->assertEmpty($piGroup->getRequests());
 
-            $this->assertEquals([$requestedUser, $pi], $piGroup->getGroupMembers());
+            $this->assertEquals([$pi->getUID(), self::$requestUid], $piGroup->getGroupMemberUIDs());
             $this->assertTrue($piGroup->userExists($requestedUser));
         } finally {
             $piGroup->removeUser($requestedUser);
@@ -56,7 +56,7 @@ public function testApproveNonexistentRequest()
         $pi = $USER;
         $piGroup = $USER->getPIGroup();
         $this->assertTrue($piGroup->exists());
-        $this->assertEquals([$pi], $piGroup->getGroupMembers());
+        $this->assertEquals([$pi->getUID()], $piGroup->getGroupMemberUIDs());
         $this->assertEmpty($piGroup->getRequests());
 
         $notRequestedUser = new UnityUser(self::$noRequestUid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
@@ -65,7 +65,7 @@ public function testApproveNonexistentRequest()
 
         try {
             $piGroup->approveUser($notRequestedUser);
-            $this->assertEquals([$pi], $piGroup->getGroupMembers());
+            $this->assertEquals([$pi->getUID()], $piGroup->getGroupMemberUIDs());
             $this->assertFalse($piGroup->userExists($notRequestedUser));
         } finally {
             $piGroup->removeUser($notRequestedUser);

test/functional/PiMemberDenyTest.php

@@ -28,7 +28,7 @@ public function testDenyRequest()
         $pi = $USER;
         $piGroup = $USER->getPIGroup();
         $this->assertTrue($piGroup->exists());
-        $this->assertEquals([$pi], $piGroup->getGroupMembers());
+        $this->assertEquals([$pi->getUID()], $piGroup->getGroupMemberUIDs());
         $this->assertEmpty($piGroup->getRequests());
         $requestedUser = new UnityUser(self::$requestUid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
         try {
@@ -37,7 +37,7 @@ public function testDenyRequest()
 
             $piGroup->denyUser($requestedUser);
             $this->assertEmpty($piGroup->getRequests());
-            $this->assertEquals([$pi], $piGroup->getGroupMembers());
+            $this->assertEquals([$pi->getUID()], $piGroup->getGroupMemberUIDs());
             $this->assertFalse($piGroup->userExists($requestedUser));
         } finally {
             $SQL->removeRequest(self::$requestUid, $piGroup->getPIUID());