replace bad isset, is_null with is_array

simonLeary42 · simonLeary42 · commit 6fa9bdc99ba6 · 2025-12-12T10:52:25.000-05:00
diff --git a/resources/lib/UnityHTTPD.php b/resources/lib/UnityHTTPD.php
@@ -238,11 +238,8 @@ public static function getPostData(string $key): mixed
     /* returns null if not found and not $throw_if_not_found */
     public static function getQueryParameter(string $key, bool $throw_if_not_found = true): mixed
     {
-        if (isset($_GET)) {
-            self::badRequest('$_GET is unset');
-        }
-        if ($_GET === null) {
-            self::badRequest('$_GET is null');
+        if (!is_array($_GET)) {
+            throw new RuntimeException('$_GET is not an array!');
         }
         if (!array_key_exists($key, $_GET)) {
             if ($throw_if_not_found) {

Original file line number	Diff line number	Diff line change
`@@ -238,11 +238,8 @@ public static function getPostData(string $key): mixed`
`238`	`238`	`/* returns null if not found and not $throw_if_not_found */`
`239`	`239`	`public static function getQueryParameter(string $key, bool $throw_if_not_found = true): mixed`
`240`	`240`	`{`
`241`		`- if (isset($_GET)) {`
`242`		`- self::badRequest('$_GET is unset');`
`243`		`- }`
`244`		`- if ($_GET === null) {`
`245`		`- self::badRequest('$_GET is null');`
	`241`	`+ if (!is_array($_GET)) {`
	`242`	`+ throw new RuntimeException('$_GET is not an array!');`
`246`	`243`	`}`
`247`	`244`	`if (!array_key_exists($key, $_GET)) {`
`248`	`245`	`if ($throw_if_not_found) {`