fix risky test

simonLeary42 · simonLeary42 · commit 56d1fb33815e · 2025-11-13T14:18:21.000-05:00
diff --git a/test/functional/InvalidEPPNTest.php b/test/functional/InvalidEPPNTest.php
@@ -15,14 +15,15 @@ public static function provider()
     public function testInitGetSSO(string $eppn, bool $is_valid): void
     {
         global $SSO;
-        self::expectNotToPerformAssertions();
         $original_server = $_SERVER;
         $original_sso = $SSO;
         if (session_status() == PHP_SESSION_ACTIVE) {
             session_write_close();
             session_id(uniqid());
         }
-        if (!$is_valid) {
+        if ($is_valid) {
+            self::expectNotToPerformAssertions();
+        } else {
             $this->expectException(SSOException::class);
         }
         try {

Original file line number	Diff line number	Diff line change
`@@ -15,14 +15,15 @@ public static function provider()`
`15`	`15`	`public function testInitGetSSO(string $eppn, bool $is_valid): void`
`16`	`16`	`{`
`17`	`17`	`global $SSO;`
`18`		`- self::expectNotToPerformAssertions();`
`19`	`18`	`$original_server = $_SERVER;`
`20`	`19`	`$original_sso = $SSO;`
`21`	`20`	`if (session_status() == PHP_SESSION_ACTIVE) {`
`22`	`21`	`session_write_close();`
`23`	`22`	`session_id(uniqid());`
`24`	`23`	`}`
`25`		`- if (!$is_valid) {`
	`24`	`+ if ($is_valid) {`
	`25`	`+ self::expectNotToPerformAssertions();`
	`26`	`+ } else {`
`26`	`27`	`$this->expectException(SSOException::class);`
`27`	`28`	`}`
`28`	`29`	`try {`