specify exit code in _die

Author: simonLeary42

workers/init.php

@@ -21,8 +21,8 @@
 
 // UnityHTTPD::die() makes no output by default
 // builtin die() makes a return code of 0, we want nonzero
-function _die($msg)
+function _die(string $msg, int $exit_code)
 {
     print $msg;
-    exit(1);
+    exit($exit_code);
 }

workers/remove-users-from-group.php

@@ -3,16 +3,16 @@
 include __DIR__ . "/init.php";
 
 if (sizeof($argv) != 3 or in_array($argv, ["-h", "--help"])) {
-    die("Usage: $argv[0] group_name filename_of_users_to_remove\n");
+    _die("Usage: $argv[0] group_name filename_of_users_to_remove\n", 0);
 }
 
 $gid = $argv[1];
 $filename = $argv[2];
 $group = new UnityGroup($gid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
 if (!$group->exists()) {
-    _die("No such group '$gid'\n");
+    _die("No such group '$gid'\n", 1);
 }
-($handle = fopen($filename, "r")) or _die("Can't open '$filename'\n");
+($handle = fopen($filename, "r")) or _die("Can't open '$filename'\n", 1);
 while (($line = fgets($handle)) !== false) {
     $uid = trim($line);
     $user = new UnityUser($uid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);

workers/update-ldap-cache.php

@@ -4,11 +4,13 @@
 
 $options = getopt("fuh", ["help"]);
 if (array_key_exists("h", $options) or array_key_exists("help", $options)) {
-    echo "arguments:
+    _die(
+        "arguments:
     f: flush cache and then update
     u: update cache even if already initialized
-    h --help: display this message\n";
-    die();
+    h --help: display this message\n",
+        0,
+    );
 }
 if (array_key_exists("f", $options)) {
     echo "flushing cache...\n";