Skip to content

Commit 384a2ce

Browse files
committed
use different array comparison function
1 parent 8a87181 commit 384a2ce

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

test/functional/PIMemberApproveTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ private function assertGroupMembers(UnityGroup $group, array $expected_members)
1111
sort($expected_members);
1212
$found_members = $group->getGroupMemberUIDs();
1313
sort($found_members);
14-
$this->assertEquals($expected_members, $found_members);
14+
$this->assertEqualsCanonicalizing($expected_members, $found_members);
1515
}
1616

1717
private function assertRequestedMembership(bool $expected, string $gid)

test/functional/PIMemberDenyTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function testDenyRequest()
3232
$pi = $USER;
3333
$piGroup = $USER->getPIGroup();
3434
$this->assertTrue($piGroup->exists());
35-
$this->assertEquals([$pi->uid], $piGroup->getGroupMemberUIDs());
35+
$this->assertEqualsCanonicalizing([$pi->uid], $piGroup->getGroupMemberUIDs());
3636
$this->assertEmpty($piGroup->getRequests());
3737
$requestedUser = new UnityUser(self::$requestUid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK);
3838
try {
@@ -41,7 +41,7 @@ public function testDenyRequest()
4141

4242
$piGroup->denyUser($requestedUser);
4343
$this->assertEmpty($piGroup->getRequests());
44-
$this->assertEquals([$pi->uid], $piGroup->getGroupMemberUIDs());
44+
$this->assertEqualsCanonicalizing([$pi->uid], $piGroup->getGroupMemberUIDs());
4545
$this->assertFalse($piGroup->memberExists($requestedUser));
4646
} finally {
4747
$SQL->removeRequest(self::$requestUid, $piGroup->gid);

test/functional/PIMemberRequestTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public function testRequestMembership()
3131
$gid = $pi_group->gid;
3232
$this->assertTrue($USER->isPI());
3333
$this->assertTrue($pi_group->exists());
34-
$this->assertEquals([$pi], $pi_group->getGroupMembers());
35-
$this->assertEquals([], $SQL->getRequests($gid));
34+
$this->assertEqualsCanonicalizing([$pi], $pi_group->getGroupMembers());
35+
$this->assertEqualsCanonicalizing([], $SQL->getRequests($gid));
3636
switchUser(...getUserNotPiNotRequestedBecomePi());
3737
$uid = $USER->uid;
3838
$this->assertFalse($USER->isPI());

0 commit comments

Comments
 (0)