remove fancy error ID that seems to make duplicates

Author: simonLeary42

resources/lib/UnityHTTPD.php

@@ -53,18 +53,6 @@ public static function redirect(?string $dest = null): never
         self::die();
     }
 
-    /*
-    generate a unique ID that can be logged and also displayed to the user when something has
-    gone wrong. This way the user can give us the ID and we can find the exact line in the log
-    file that represents their issue.
-    assumes that a session is started and has a good unique session_id
-    */
-    public static function errorID(?\Throwable $e = null): string
-    {
-        $e ??= new stdClass();
-        return md5(strval(session_id()) . spl_object_id($e));
-    }
-
     /*
     generates a unique error ID, writes to error log, and then:
         if "html_errors" is disabled in the PHP config file:
@@ -84,7 +72,7 @@ public static function gracefulDie(
         int $http_response_code = 200,
         mixed $data = null,
     ): never {
-        $errorid = self::errorID($error);
+        $errorid = uniqid();
         $suffix = sprintf(
             "Please notify a Unity admin at %s. Error ID: %s.",
             CONFIG["mail"]["support"],
@@ -148,9 +136,6 @@ public static function errorLog(
         $output["REMOTE_USER"] = $_SERVER["REMOTE_USER"] ?? null;
         $output["REMOTE_ADDR"] = $_SERVER["REMOTE_ADDR"] ?? null;
         $output["_REQUEST"] = $_REQUEST;
-        if (is_null($errorid) && !is_null($error)) {
-            $errorid = self::errorID($error);
-        }
         if (!is_null($errorid)) {
             $output["errorid"] = $errorid;
         }