add assertions

Author: simonLeary42

test/functional/PIMemberApproveTest.php

@@ -85,11 +85,13 @@ public function testApproveMemberByPI()
         $user_to_approve_args = getUnqualifiedUser();
         $pi_user_args = getUserIsPIHasNoMembersNoMemberRequests();
         switchUser(...$pi_user_args);
+        $pi_uid = $USER->uid;
         $pi_group = $USER->getPIGroup();
         $gid = $pi_group->gid;
         switchUser(...$user_to_approve_args);
         $this->assertTrue($USER->exists());
         $this->assertTrue($pi_group->exists());
+        $this->assertGroupMembers($pi_group, [$pi_uid]);
         $this->assertTrue(!$pi_group->memberExists($USER));
         $this->assertRequestedMembership(false, $gid);
         try {
@@ -136,6 +138,7 @@ public function testApproveMemberByPI()
         } finally {
             switchUser(...$user_to_approve_args);
             ensureUserNotInPIGroup($pi_group);
+            $this->assertGroupMembers($pi_group, [$pi_uid]);
         }
     }
 
@@ -145,10 +148,12 @@ public function testApproveMemberByAdmin()
         $user_to_approve_args = getUnqualifiedUser();
         switchUser(...getUserIsPIHasNoMembersNoMemberRequests());
         $pi_group = $USER->getPIGroup();
+        $pi_uid = $USER->uid;
         $gid = $pi_group->gid;
         switchUser(...$user_to_approve_args);
         $this->assertTrue($USER->exists());
         $this->assertTrue($pi_group->exists());
+        $this->assertGroupMembers($pi_group, [$pi_uid]);
         $this->assertTrue(!$pi_group->memberExists($USER));
         $this->assertRequestedMembership(false, $gid);
         try {
@@ -195,6 +200,7 @@ public function testApproveMemberByAdmin()
         } finally {
             switchUser(...$user_to_approve_args);
             ensureUserNotInPIGroup($pi_group);
+            $this->assertGroupMembers($pi_group, [$pi_uid]);
         }
     }
 }