test PI membership requests using mail

Author: simonLeary42

test/functional/NewUserTest.php

@@ -40,12 +40,12 @@ private function requestGroupCreation()
         ]);
     }
 
-    private function requestGroupMembership(string $gid)
+    private function requestGroupMembership(string $gid_or_mail)
     {
         http_post(__DIR__ . "/../../webroot/panel/new_account.php", [
             "new_user_sel" => "not_pi",
             "eula" => "agree",
-            "pi" => $gid,
+            "pi" => $gid_or_mail,
         ]);
     }
 
@@ -294,7 +294,7 @@ public function testCreateUserByJoinGoupByAdmin($user_to_create_args, $expected_
             $this->cancelAllRequests();
             $this->assertRequestedMembership(false, $gid);
 
-            $this->requestGroupMembership($pi_group->gid);
+            $this->requestGroupMembership($pi_group->getOwner()->getMail());
             $this->assertTrue($pi_group->requestExists($USER));
             $this->assertRequestedMembership(true, $gid);
 

test/functional/PIMemberRequestTest.php

@@ -5,11 +5,11 @@
 
 class PiMemberRequestTest extends TestCase
 {
-    private function requestMembership(string $gid)
+    private function requestMembership(string $gid_or_mail)
     {
         http_post(__DIR__ . "/../../webroot/panel/groups.php", [
             "form_type" => "addPIform",
-            "pi" => $gid,
+            "pi" => $gid_or_mail,
         ]);
     }
 
@@ -42,7 +42,7 @@ public function testRequestMembership()
             $this->assertTrue($SQL->requestExists($uid, $gid));
             $this->cancelRequest($gid);
             $this->assertFalse($SQL->requestExists($uid, $gid));
-            $this->requestMembership($gid);
+            $this->requestMembership($pi_group->getOwner()->getMail());
             $this->assertTrue($SQL->requestExists($uid, $gid));
         } finally {
             if ($SQL->requestExists($uid, $gid)) {