We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IV4Router
I've noticed a discrepancy in the Swapping on Uniswap v4
In section 3.4: Preparing the Swap Inputs, the example shows the IV4Router.ExactInputSingleParams struct with six parameters:
IV4Router.ExactInputSingleParams
IV4Router.ExactInputSingleParams({ poolKey: key, zeroForOne: true, // true if we're swapping token0 for token1 amountIn: amountIn, // amount of tokens we're swapping amountOutMinimum: minAmountOut, // minimum amount we expect to receive @> sqrtPriceLimitX96: uint160(0), // no price limit set hookData: bytes("") // no hook data needed })
However, when following the import path:
import { IV4Router } from "@uniswap/v4-periphery/contracts/interfaces/IV4Router.sol";
The actual interface for ExactInputSingleParams is:
ExactInputSingleParams
/// @notice Parameters for a single-hop exact-input swap struct ExactInputSingleParams { PoolKey poolKey; bool zeroForOne; uint128 amountIn; uint128 amountOutMinimum; bytes hookData; }
sqrtPriceLimitX96
Could you confirm whether the docs are outdated or if sqrtPriceLimitX96 was intended to be part of ExactInputSingleParams?
Thanks!
The text was updated successfully, but these errors were encountered:
saucepoint
Successfully merging a pull request may close this issue.
I've noticed a discrepancy in the Swapping on Uniswap v4
Problem
In section 3.4: Preparing the Swap Inputs, the example shows the
IV4Router.ExactInputSingleParams
struct with six parameters:However, when following the import path:
The actual interface for
ExactInputSingleParams
is:Issue
sqrtPriceLimitX96
, which is not present in the actual interface.sqrtPriceLimitX96
parameter.Expected Fix
sqrtPriceLimitX96
, or clarify if an updated contract interface includes it.Could you confirm whether the docs are outdated or if
sqrtPriceLimitX96
was intended to be part ofExactInputSingleParams
?Thanks!
The text was updated successfully, but these errors were encountered: