Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The state of re-registration #27

Open
karmanyaahm opened this issue Dec 18, 2023 · 4 comments
Open

The state of re-registration #27

karmanyaahm opened this issue Dec 18, 2023 · 4 comments

Comments

@karmanyaahm
Copy link
Member

Just a survey on how apps deal with:

  1. NEW_ENDPOINT The exact same endpoint
  2. NEW_ENDPOINT Different endpoint
  3. UNREGISTERED
@karmanyaahm
Copy link
Member Author

karmanyaahm commented Dec 18, 2023

Tusky:

@iNPUTmice observed that Tusky doesn't retry anything if the connection with the server is bad.

NEW_ENDPOINT: It re-registers every time it receives a NEW_ENDPOINT. Creates new WebPush keys on every NEW_ENDPOINT, even if the endpoint is the same. Mastodon automatically overrides the old endpoint with the new one.
UNREGISTERED: It looks like it unregisters properly.
Android's notification setting: Does Tusky unregister if notifications are turned off in Android settings?

@p1gp1g
Copy link
Member

p1gp1g commented Dec 18, 2023

The issue is Mastodon doesn't override the push endpoint, but add it

@karmanyaahm
Copy link
Member Author

karmanyaahm commented Dec 18, 2023

Podverse:
Wow it apparently has full aes128gcm webpush decryption support. Didn't know that.
The podverse server doesn't do anything when receiving 404's or any status code for that matter.

NEW_ENDPOINT: Appropriately, it doesn't talk to the server at all if the endpoint doesn't change. If the endpoint changes, it creates/updates the device. Doesn't look like there's any retry logic on a bad connection or server outage.
UNREGISTERED: Podverse-rn doesn't handle Unregistered. The native part broadcasts UnifiedPushUnregistered, but nothing in JS receives it.

@p1gp1g
Copy link
Member

p1gp1g commented Dec 19, 2023

The issue is Mastodon doesn't override the push endpoint, but add it

mastodon/mastodon#27858 the issue with multiple push subscriptions for a single device on mastodon has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants