Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with CircleCI previews #945

Open
exoticDFT opened this issue Oct 7, 2022 · 1 comment
Open

Issue with CircleCI previews #945

exoticDFT opened this issue Oct 7, 2022 · 1 comment
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed

Comments

@exoticDFT
Copy link
Member

    > The idea looks good. The links don't work in the preview, but my guess is this is an issue with the preview rather than the site.

I've been noticing this on the last couple of PRs I've made as well.

I think this is partially an issue either with CircleCI itself or the way we have it setup. The artifacts site doesn't seem to be able to handle the URL paths we expect. For example, we expect people to be able to go to https://us-rse.org/events/2022/2022-12-AGM/, but CircleCI seems to need us to add index.html to the end of the link. Oddly, this doesn't seem to always work though. E.g. at least two of the links on the US-RSE landing page don't work after adding the index.html (and fixing the other issue I mention below.)

Also, we may have a problem with the way we use "baseurl" (maybe?), at least in terms of CircleCI. I've noticed just about every link you click on in CircleCI artifacts adds an extra "https://output.circle-artifacts.com/" to the front of the URL, e.g. https://output.circle-artifacts.com/https://output.circle-artifacts.com/output/job/69a12ffd-95a9-4823-9007-26c8df8751a3/artifacts/0/usrse.github.io/working-groups. But if you drop the additional https bit and add index.html, the link works...https://output.circle-artifacts.com/output/job/69a12ffd-95a9-4823-9007-26c8df8751a3/artifacts/0/usrse.github.io/working-groups/index.html.

So with this and the index.html expectation, no links work in the preview correctly. You have to go back to the overarching artifacts page and find the page you want to view.

Originally posted by @exoticDFT in #942 (comment)

@crd477
Copy link
Contributor

crd477 commented Mar 31, 2023

With respect to the first issue, it seems unlikely that CircleCI is interested in doing anything to address it. See:
https://discuss.circleci.com/t/static-websites-in-artifacts/37093
which references:
https://discuss.circleci.com/t/circle-artifacts-com-not-using-index-html/320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants