Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic_demo.ipynb check_valve must be a Boolean #475

Open
linasela opened this issue Feb 11, 2025 · 3 comments
Open

basic_demo.ipynb check_valve must be a Boolean #475

linasela opened this issue Feb 11, 2025 · 3 comments
Labels

Comments

@linasela
Copy link

when running 'basic_demo.ipynb' in section 3.6 with
Python 3.9.21
WNTR version: 1.2.0
the command wn2 = wntr.network.read_shapefile(shapefile_dirs) gives the following error:

Image

@kaklise
Copy link
Collaborator

kaklise commented Feb 19, 2025

Thanks @linasela. I'm not able to replicate this issue. I see that check_valve is '0' and then converted to False. Can you send us the value of check_valve before the assert statement?

@linasela
Copy link
Author

linasela commented Feb 19, 2025

Thanks @kaklise, looks like it's boolean

Image

Also, this is the same code we used in the workshop during the summer. You can run it in binder https://mybinder.org/v2/gh/meghnathomas/wdsa-ccwi-workshop/HEAD
and it generates the same error I get running it locally.

Thanks

@angusmcb
Copy link
Contributor

I don't think that it's the cause of the issue, but note that I think you would need to check pipe.cv

See here: #468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants