Skip to content

Commit 2f0be74

Browse files
committed
fix(ts-interface-generator): properly type getters
So that a definition of `someFunc: { type: "function", group: "Behavior", defaultValue: null }` correctly generates : `getSomeFunc(): Function | null;`
1 parent 02b04f7 commit 2f0be74

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

‎packages/ts-interface-generator/src/astGenerationHelper.ts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,17 +1090,21 @@ function createTSTypeNode(
10901090
);
10911091

10921092
case "object":
1093-
return factory.createKeywordTypeNode(ts.SyntaxKind.ObjectKeyword);
1093+
return factory.createUnionTypeNode([
1094+
factory.createKeywordTypeNode(ts.SyntaxKind.ObjectKeyword),
1095+
factory.createLiteralTypeNode(factory.createNull()),
1096+
]);
10941097

10951098
case "object[]":
10961099
return factory.createArrayTypeNode(
10971100
factory.createKeywordTypeNode(ts.SyntaxKind.ObjectKeyword),
10981101
);
10991102

11001103
case "function":
1101-
return factory.createTypeReferenceNode(
1102-
factory.createIdentifier("Function"),
1103-
);
1104+
return factory.createUnionTypeNode([
1105+
factory.createTypeReferenceNode(factory.createIdentifier("Function")),
1106+
factory.createLiteralTypeNode(factory.createNull()),
1107+
]);
11041108

11051109
case "function[]":
11061110
return factory.createArrayTypeNode(

0 commit comments

Comments
 (0)