Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected text label behaviour when using search (points get filtered, labels do not) #38

Open
iblind opened this issue Sep 11, 2024 · 3 comments

Comments

@iblind
Copy link

iblind commented Sep 11, 2024

I was using the search functionality to filter out points in the plot, but realized that while the points were being filtered, the labels for the clusters were not. Here is an example:

image

The expected baseline behaviour, to me, would be for these to be filtered out as well. I've fixed this locally in the HTML once the plot has been generated, but if this sort of functionality is desirable, I can take a stab at a branch and submitting a pull request.

Regardless, thanks for the amazing work on the library so far, it's been tremendously helpful in my work!

@lmcinnes
Copy link
Contributor

Filtering the labels was not the expected default in that retaining them can be useful for providing some reference for where in the space you are looking. I can see the value in filtering them though, and I would definitely be very receptive if you wanted to look at making that an option that could be enabled.

On that front I have been doing quite a bit of work refactoring selection handling (and other things) lately, so if you were interested in implementing such functionality I would suggest holding off for a week or two until I can get the refactored changes merged into main.

@iblind
Copy link
Author

iblind commented Sep 11, 2024

Perf, I'll keep an eye out for the new release and will aim to jump in afterwards.

@lmcinnes
Copy link
Contributor

The big update is done so you are welcome to have a crack at optionally having labels show dependent on selection...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants