Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gibbs(; m=HMC(0.2, 3), s=PG(10)) in favour of Gibbs(:m=>HMC(0.2, 3), :s=>PG(10)) #2442

Closed
yebai opened this issue Dec 18, 2024 · 1 comment · Fixed by #2456
Closed

Remove Gibbs(; m=HMC(0.2, 3), s=PG(10)) in favour of Gibbs(:m=>HMC(0.2, 3), :s=>PG(10)) #2442

yebai opened this issue Dec 18, 2024 · 1 comment · Fixed by #2456
Assignees
@mhauru

Comments

@yebai
Copy link
Member

yebai commented Dec 18, 2024

Markus and I also discussed keeping only the syntax Gibbs(m=>HMC(0.2, 3), s=>PG(10)) for the new Gibbs sampler to keep the interface simple. The two ways are identical, so they are redundant.

For parameters with complex variable names, we will do Gibbs(@varname(m[1])=>HMC(0.2, 3), @varname(s[1])=>PG(10)), for example.
@mhauru mhauru self-assigned this Jan 6, 2025
@mhauru
Copy link
Member

mhauru commented Jan 6, 2025

I'll make this my top priority now, to get this done before we release a new version with the new Gibbs, since removing the constructor call is breaking.

@mhauru mhauru mentioned this issue Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhauru mhauru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework Gibbs constructors TuringLang/Turing.jl
2 participants
@yebai @mhauru