Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gibbs test slowdown #2445

Open
penelopeysm opened this issue Dec 19, 2024 · 2 comments
Open

Gibbs test slowdown #2445

penelopeysm opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels

Comments

@penelopeysm
Copy link
Member

Since #2328 was merged, the time it takes to run mcmc/gibbs is far longer than the time it used to take to run mcmc/gibbs plus experimental/gibbs.

Need to investigate the cause for this.

@mhauru mhauru self-assigned this Jan 6, 2025
@mhauru
Copy link
Member

mhauru commented Jan 7, 2025

Could you point me to a CI run where this is evident? I'm looking at this one as an example for the pre-merge times, and the times for experimental seem equally long (and wildly variable): https://github.com/TuringLang/Turing.jl/actions/runs/12325358448/job/34404526010

@mhauru
Copy link
Member

mhauru commented Jan 7, 2025

There's definitely something weird going on between Julia v1.10 and v1.11 though, the latter being 2-3 times slower in cases I'm looking at. @yebai, you mentioned that you think this is due to a Libtask issue. Is the root of the problem known? Would it still be helpful to narrow this down, to confirm that if we leave out all the particle Gibbs tests then v1.10 and v1.11 become comparable in runtime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants