Rework Gibbs constructors #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2456 +/- ##
==========================================
- Coverage 85.39% 85.00% -0.39%
==========================================
Files 21 21
Lines 1588 1581 -7
==========================================
- Hits 1356 1344 -12
- Misses 232 237 +5 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12656843744Details
💛 - Coveralls |
penelopeysm
reviewed
Jan 7, 2025
|
Otherwise, super happy with this, I like APIs that are precise as opposed to ones that let you do whatever 👍😄 |
|
@yebai are you happy with this interface? The test failures are two cases of x86 running out of memory and one case of some coveralls network error. |
penelopeysm
approved these changes
Jan 8, 2025
|
Thanks @mhauru! I am happy with the interface; feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to removing the kwarg constructor as discussed in #2442, I also removed the
NamedTupleandDictconstructors, to keep the interface simple. I don't see many people using them, and the user can trivially callGibbs(my_dict...)orGibbs(pairs(my_namedtuple)...)if need be.The PR also simplifies a few unrelated lines and expands some docstrings.
Closes #2442