You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have some code in nr-common and I think we can import it from nr-server but I can't import it from nr-app. There are all kinds of errors, some of which I thought I'd fixed in 99fd596 but it turns out, I haven't.
Goals:
Typescript code in nr-common
We should be able to use packages in nr-common (eg zod)
Code should be usable from the expo app (nr-app)
Code should be usable for deno (and probably from node)
Nice to have:
Code should be imported without a build step
Using workspaces, you typically need to run pnpm i or similar after every change in nr-common which creates unexpected weirdness because changes don't immediately propagate
TypeScript should be imported rather than *.js and *.d.ts
The text was updated successfully, but these errors were encountered:
This has turned to be wildly difficult. I ended up copying nr-common into nr-server and even then there were still problems. Some of the issues I can remember:
When we built the docker container for nr-server all the files in nr-common are outside of it's docker root and so they're not available in the container
The dependencies in nr-common are not available in nr-server, so deno complains it can't find zod
Further issues where @babel/runtime is missing in nr-common which linked to this issue comment which is why I installed it into nr-common and fixed that error.
We have some code in
nr-common
and I think we can import it fromnr-server
but I can't import it fromnr-app
. There are all kinds of errors, some of which I thought I'd fixed in 99fd596 but it turns out, I haven't.Goals:
nr-common
nr-common
(eg zod)nr-app
)Nice to have:
pnpm i
or similar after every change innr-common
which creates unexpected weirdness because changes don't immediately propagate*.js
and*.d.ts
The text was updated successfully, but these errors were encountered: