Skip to content

Commit c52be8b

Browse files
committed
chore(ci): using signing params instead of hook
1 parent 25a8b77 commit c52be8b

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

.github/actions/build-electron/action.yml

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ runs:
2525
- name: Run electron-forge
2626
shell: cmd
2727
run: npm run make-electron -- --arch=${{ inputs.arch }}
28+
env:
29+
WINDOWS_SIGNTOOL_PATH: "C:\\ev_signer_trilium\\ev_signer_trilium.exe"
30+
WINDOWS_SIGN_WITH_PARAMS: --executable
2831
- uses: actions/upload-artifact@v4
2932
with:
3033
name: Artifacts

.github/workflows/main.yml

+3
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ jobs:
3838
os: ${{ matrix.os.name }}
3939
arch: ${{ matrix.arch }}
4040
extension: ${{ matrix.os.extension }}
41+
env:
42+
WINDOWS_SIGNTOOL_PATH: "C:\\ev_signer_trilium\\ev_signer_trilium.exe"
43+
WINDOWS_SIGN_WITH_PARAMS: --executable
4144
- name: Publish artifacts
4245
uses: actions/upload-artifact@v4
4346
with:

forge.config.cjs

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const path = require("path");
22
const fs = require("fs-extra");
3-
43
const APP_NAME = "TriliumNext Notes";
54

65
module.exports = {
@@ -10,6 +9,12 @@ module.exports = {
109
overwrite: true,
1110
asar: true,
1211
icon: "./images/app-icons/icon",
12+
signToolPath: "C:\\ev_signer_trilium\\ev_signer_trilium.exe",
13+
signWithParams: "--executable",
14+
windowsSign: {
15+
signToolPath: "C:\\ev_signer_trilium\\ev_signer_trilium.exe",
16+
signWithParams: "--executable",
17+
},
1318
extraResource: [
1419
// Moved to root
1520
...getExtraResourcesForPlatform(),
@@ -65,7 +70,8 @@ module.exports = {
6570
setupIcon: "./images/app-icons/icon.ico",
6671
loadingGif: "./images/app-icons/win/setup-banner.gif",
6772
windowsSign: {
68-
hookModulePath: "./bin/sign-windows.js"
73+
signToolPath: "C:\\ev_signer_trilium\\ev_signer_trilium.exe",
74+
signWithParams: "--executable",
6975
}
7076
}
7177
},

0 commit comments

Comments
 (0)