Skip to content

Commit

Permalink
Removed volume instruction
Browse files Browse the repository at this point in the history
  • Loading branch information
@TrafeX
TrafeX committed Apr 20, 2020
1 parent 1780ba1 commit 772d7ae
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ RUN chown -R nobody.nobody /var/www/html && \
chown -R nobody.nobody /var/lib/nginx && \
chown -R nobody.nobody /var/log/nginx

# Make the document root a volume
VOLUME /var/www/html

# Switch to use a non-root user from here on
USER nobody

Expand Down

1 comment on commit 772d7ae

@erseco
Copy link
Contributor

@erseco erseco commented on 772d7ae Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change! Volumes in Dockerfile are not recommended, and is a pain when using this image as base, here you can read more info about why is not recommended use VOLUME in Dockerfiles Thanks!

Please sign in to comment.