Suggestion: Add Rollbacks for damage to SiegeZone wilderness

[Goosius1]

Is your feature request related to a problem? Please describe.
There are 3 relevant problems

• Siegezone wilderness generally is an inconvenience to clean up post-siege for the defender.
• Traps in the wilderness generally make battles less fun.
• Wall breaching is a hard sell to servers used to zero town destruction.

Describe the solution you'd like

• The solution to all 3 issues is block rollbacks in the besieged town and siegezone wilderness
• Interval:
  • in the besieged town, after each battle session.
  • in the wilderness after each battle session (bu bye traps). Longer intervals here would suit trap warfare aficionados (but seriously how many of those are there?)
• Possibly exclude block changes in the town by town residents..

Describe alternatives you've considered
Na

Additional context
Na

[Firav]

How frequent are you suggesting these rollbacks be? After every battle session? Every real day? After the end of the total siege?

[Goosius1]

I'm thinking at the end of each battle session.

Because otherwise a defender's walls might be effective in just 1-3 sessions,
and be in an unusable demolished state in every other session, barring extensive rebuilding efforts.

Effects:

1. This would seem pretty mean spirited to defenders, who have spend countless hours building up nice fortifications
2. This would presumably be less fun for attackers too, because in most sessions they might, instead of fighting to scale the walls, end up rather boringly walking in through existing holes and mopping up a few dispirited town defenders within the rubble.

[Firav]

I think that rollbacks on the end of each battle session could be excessive, and upset attackers moreover. My suggestion would be at the end of every towny day, so that the attackers have had a chance to knock down the defenses, while defenders still reap the benefit of rebuilt defenses.

On the technical standpoint of this suggestion, I feel it can become quite complex attempting to track the actions of users within these zones. Do you plan on logging the actions of individual players? Or taking a snapshot of the area for a rollback function to revert to?

[Goosius1]

What's your basis for thinking end-of-session is excessive? Points 1 and 2 in my previous post lay out its suitability for both the attacker and the defender.

Technically, I have no freaking clue yet :🤣

[Firav]

What's your basis for thinking end-of-session is excessive? Points 1 and 2 in my previous post lay out its suitability for both the attacker and the defender.

Players who are the attackers are obviously trying to make forward objective to tear down defenses and suppress defending forces within the siege zone. I believe attackers would see it as demoralizing to have the defending towns walls/defenses just pop right back up after a single session. While attackers have done all the work to tear down the walls and defenses, it's just reverted after 50 minutes of siege without any effort of the defending town.

Technically, I have no freaking clue yet :🤣

I've been trying to think of some solutions myself, but I dont really have much for it yet haha

[Goosius1]

I believe attackers would see it as demoralizing > to have the defending towns walls/defenses
just pop right back up after a single session.

Consider the context though. The wall breaching feature gives the attacker 2 completely new capabilities, which they never had before

1. Outmaneuvering the defender in their own town
2. A new source of battle points in the WB bonus

Imagine if an attacker typed: "I find it difficult to claim all these new rewards which I never had before. I'm demoralized." ...That attitude would be really entitled wouldn't it?

Meanwhile the defender surely has a much stronger case to furiously complain about the whole thing?. Never mind suggesting that they wait even longer for rollbacks, but their besieger was just granted, for free, a new ability to wreck their walls, get into their safe rooms, plus get extra battle points. Splutter!:🤯😂

[Goosius1]

FYI

Pesto did some research on adding a SW rollback feature.

The results are shownhere:
https://youtu.be/CDmrkBS2pr4

_Pesto — 03/22/2022
Yeah this is based on Towny's rollback
Thats pretty much it lol

Goosius1 — 03/22/2022
Haha well great! Thanks it's good information. Did you notice any problems with using the Towny rollback code?

_Pesto — 03/22/2022
Uhh not major problems but there's a few I can think of:

• Rolling back containers might cause item duping
• There needs to be some persistence with rollback queues e.g. what if the server is restarted during an active rollback
• Need to consider other towns that are not part of the siege but are within siege radius

[Goosius1]

FYI Also

CCNet currently use a fork of this to do their rollbacks:

https://github.com/galacticwarrior9/ExplosionReversal

The core plugin of ExplosionReversal seems to be abandoned

[Goosius1]

Here is another potential option for this

1. Use coreprotect
2. Ensure that when a battle session starts, coreprotect is recording
3. During a session, if any block is destroyed/exploded, do not drop anything.
4. After the session, roll back some of the siegezone (You probably won't be able to get it all, because the siegezone is circular, but the coreprotect boundary is square)