-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Cropper Minimum Size #46
Comments
Hi @anuj77! Thanks a lot for that! I'm glad you like the look of my library! Ummm, not at the moment... The cropper lets you choose a specific aspect ratio to clamp to, but no explicit size limiting yet. That's definitely a good idea though. I'll leave this issue open to remind me to add that at some point. |
This is definitely something I could use as well. My biggest issue with PEPhotoCropEditor was a lack of minimum crop support. |
Thanks for the feedback! I'm still swamped, so I've got no time to look into this myself. Feel free to try it yourself and file a PR! :) |
Hey @TimOliver , |
Hi @harishchopra86! Thanks a lot! Glad you're liking it! Nope, nothing yet sorry! I've been incredibly busy helping my company launch a new thing as of late, so I've only now gotten a chance to start looking at my open source libraries again. I'm interested in doing this one for the challenge, but there's still a few nitty gritty implementation details to work out:
Honestly, if anyone else wants to try adding it, that would be a huge help. :) |
Hi @TimOliver I had a look into https://realm.io and it is a revolutionary product. Below are my inline thoughts over the image size implementation points: What is required to calculate the minimum size the crop box can be when the user resizes it.
What is required to calculate the maximum zoom a user can pinch-in.
What happens when the screen rotates.
Regards, |
Thanks @harishchopra86! Glad you like the look of it! :) Haha yeah, you're right in all of those points; what I was referring to was the actual code logic necessary to enforce those types of constraints. It shouldn't be much code... but it's all math. XD |
Hi @TimOliver, I am facing one problem by using this code that is Zoom scale limitation. I want to fix zoom scale because when I zoom my image then it is reduced from actual required image size. For example :- If I require my image to fit in size 300_450 so I have given crop box with 2:3 aspect ratio and can crop the image in it. But I can keep zooming the image and the zooming is not restricted and at last I get image of very small size like 50_75, etc. So, is there any mechanism by which I can stop image zoom when the image size has reached the minimum size OR Dropbox size. Please advise. Regards, |
Hey tim, Thanks for such a great library. Even i want this capping feature of minimum resolution. Please can you let me know if you will update it soon. |
Hello,
Thank you for this amazing cropper code.
I have one requirement where I need to limit the cropper to certain height and width.
I need to set a thumbnail from an image.The image could be tall(1400x600 image resolution from the gallery) or wide(600x1400 image resolution from the gallery), but the thumbnail should be in 4:3 ratio(of image resolution) only.So cropper should be in 4:3 with minimum height and width of 400 x 300.
If a user selects an image is of size 2154x1616, the cropper should let user crop until image size become 400x300.If a user is trying to crop an image even after the image is 400x300, cropper should not let user.
Is there any way in current code to do this?
The text was updated successfully, but these errors were encountered: