Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Discard Changes #259

Open
2 tasks done
gerardojchv opened this issue Mar 23, 2018 · 1 comment
Open
2 tasks done

Implement Discard Changes #259

gerardojchv opened this issue Mar 23, 2018 · 1 comment

Comments

@gerardojchv
Copy link

  • I have read this issue template and provided all possible information.
  • I'm using CocoaPods and have run pod update before filing this issue.

Questions

When changes are made to the image and the cancel button is pressed, I want to ask the user "Discard changes".

Hardware / Software

Which version of the library were you using?
Master. Swift
Which version of iOS are you running?
11.2.6
What model of iOS device were you testing on?
Iphone 6s
If using CocoaPods, which version of CocoaPods are you on?
1.4.0

Goals

I want to ask the user "Discard Changes"

Expected Results

When you press cancel, know if there was a change in the original image

Actual Results

the cropViewController is closed without asking

Steps to Reproduce

  1. Crop image
  2. Press cancel button

The pod is an excellent job. Thanks.

@gerardojchv gerardojchv changed the title Implement Discard Changes? Implement Discard Changes? [question Label] Mar 23, 2018
@gerardojchv gerardojchv changed the title Implement Discard Changes? [question Label] Implement Discard Changes? Mar 23, 2018
@TimOliver TimOliver changed the title Implement Discard Changes? Implement Discard Changes Jul 22, 2018
@TimOliver
Copy link
Owner

Oh! Fantastic idea @gerardojchv! That should be really simple to add too.

I'm strapped for time, so if anyone else wants to take it up, that'd be great! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants