Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2255 #2256 Overload AddKubernetes method with KubeClientOptions param for the discovery provider #2257

Merged
merged 9 commits into from
Jan 30, 2025
Merged

#2255 #2256 Overload AddKubernetes method with KubeClientOptions param for the discovery provider #2257

merged 9 commits into from
Jan 30, 2025

Conversation

raman-m
Copy link
Member

@raman-m raman-m commented Jan 24, 2025 •
edited
Loading

Closes #2255 #2256

Proposed Changes

  • Added new overloaded AddKubernetes(this IOcelotBuilder, Action<KubeClientOptions>, ...) method
  • Updated Kubernetes docs
  • Updated Kubernetes sample

@raman-m
Add new overloaded Ocelot builder extension-method...
00c2cab 
...with Action<KubeClientOptions> required parameter
@raman-m raman-m added Service Discovery Ocelot feature: Service Discovery Configuration Ocelot feature: Configuration Kubernetes Service discovery by Kubernetes NET9 .NET 9 release labels Jan 24, 2025
@raman-m raman-m added this to the .NET 9 milestone Jan 24, 2025
@raman-m raman-m self-assigned this Jan 24, 2025
@raman-m raman-m requested review from RaynaldM and ggnaegi January 24, 2025 19:48
@raman-m
Copy link
Member Author

raman-m commented Jan 24, 2025

@chrisbecke Welcome to code review!

@raman-m raman-m changed the title #2255 #2256 Add new overloaded Ocelot builder extension-method for Kubernetes provider #2255 #2256 An overloaded Ocelot builder extension-method with options param for the Kubernetes provider Jan 24, 2025
@raman-m raman-m changed the title #2255 #2256 An overloaded Ocelot builder extension-method with options param for the Kubernetes provider #2255 #2256 Overload IOcelotBuilder extension-method with options param for the Kubernetes provider Jan 25, 2025
@raman-m raman-m changed the title #2255 #2256 Overload IOcelotBuilder extension-method with options param for the Kubernetes provider #2255 #2256 Overload AddKubernetes method with KubeClientOptions param for the discovery provider Jan 25, 2025
@raman-m
Copy link
Member Author

raman-m commented Jan 28, 2025 •
edited
Loading

TODO

  • Unit & acceptance testing → Done in d6346e7

raman-m
raman-m commented Jan 30, 2025
View reviewed changes
Copy link
Member Author

@raman-m raman-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for delivery ✅

@raman-m raman-m merged commit 4b6b96a into develop Jan 30, 2025
1 check passed
@raman-m raman-m deleted the raman-m/2256 branch January 30, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaynaldM RaynaldM Awaiting requested review from RaynaldM

@ggnaegi ggnaegi Awaiting requested review from ggnaegi

Assignees

@raman-m raman-m

Labels
Configuration Ocelot feature: Configuration Kubernetes Service discovery by Kubernetes NET9 .NET 9 release Service Discovery Ocelot feature: Service Discovery
Projects
None yet
Milestone
.NET 9
Development

Successfully merging this pull request may close these issues.

How to provide Host to KubernetesServiceDiscoveryProvider?
1 participant
@raman-m